gce: allow TCP metrics ports in GCE firewall - #18545
Merged
kubernetes-prow[bot] merged 1 commit intoJul 14, 2026
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
from
July 9, 2026 09:38
2aa9c38 to
867adae
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
6 times, most recently
from
July 10, 2026 09:50
9207ae4 to
d03a6c0
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
4 times, most recently
from
July 10, 2026 11:15
d8d83ed to
cb2d063
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
3 times, most recently
from
July 10, 2026 12:33
83605d7 to
cc40fc8
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
from
July 13, 2026 07:53
f29761c to
66eb511
Compare
Qqkyu
marked this pull request as ready for review
July 13, 2026 07:54
hakman
requested changes
Jul 13, 2026
| Allowed: []string{ | ||
| fmt.Sprintf("tcp:%d", wellknownports.KubeAPIServer), | ||
| fmt.Sprintf("tcp:%d", wellknownports.KubeletAPI), | ||
| fmt.Sprintf("tcp:%d", wellknownports.KopsControllerPort), |
Member
There was a problem hiding this comment.
Probably best to keep open for any CNI.
Suggested change
| fmt.Sprintf("tcp:%d", wellknownports.KopsControllerPort), | |
| // Metrics ports for control plane components, so they can be scraped from nodes. | |
| fmt.Sprintf("tcp:%d", wellknownports.KubeControllerManagerMetricsPort), | |
| fmt.Sprintf("tcp:%d", wellknownports.KubeSchedulerMetricsPort), | |
| fmt.Sprintf("tcp:%d", wellknownports.KubeProxyMetricsPort), | |
| fmt.Sprintf("tcp:%d", wellknownports.EtcdMetricsPort), |
Comment on lines
+152
to
+155
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeControllerManagerMetricsPort)) | ||
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeSchedulerMetricsPort)) | ||
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeProxyMetricsPort)) | ||
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.EtcdMetricsPort)) |
Member
There was a problem hiding this comment.
Suggested change
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeControllerManagerMetricsPort)) | |
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeSchedulerMetricsPort)) | |
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.KubeProxyMetricsPort)) | |
| t.Allowed = append(t.Allowed, fmt.Sprintf("tcp:%d", wellknownports.EtcdMetricsPort)) |
Comment on lines
163
to
168
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
from
July 14, 2026 09:12
66eb511 to
7bb3452
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
from
July 14, 2026 09:26
7bb3452 to
31cdf6b
Compare
Qqkyu
force-pushed
the
gce-calico-vxlan-firewall
branch
from
July 14, 2026 10:22
31cdf6b to
a22a194
Compare
hakman
approved these changes
Jul 14, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
merged commit Jul 14, 2026
572dbe4
into
kubernetes:master
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR opens the GCE ingress firewall ports required for Prometheus metrics collection in Calico-based clusters.
Why is this change needed?
When the Prometheus server is enabled in a kOps cluster on GCE, it attempts to scrape metrics from control plane components (Kubelet, Kube-Controller-Manager, Kube-Scheduler, Kube-Proxy, Etcd) on TCP ports
10249,10257,10259, and2382.Historically, kOps only opened these metrics ports for GCE IP Alias / Kindnet networks. However, this created a gap for Calico-based clusters, where these ports remained blocked, causing Prometheus scraping to fail with connection timeouts.