Support running custom etcd versions by setting version and image - #18525
Merged
Merged
Conversation
Setting both version and image on an etcd cluster runs an etcd version that kops does not bundle: the etcd and etcdctl binaries for the given version are sourced from the given image. Both fields must be set together, and only when creating a new etcd cluster; once the cluster exists, the image cannot be added, changed or removed, and the version cannot be changed while an image is set. With a custom image, only the selected version's binaries are made available to etcd-manager, so restoring backups that require the binaries of a bundled version is not supported. Also remove the SkipEtcdVersionCheck feature flag: it only skipped the supported-version check and could not make an unbundled version work.
Member
|
/cc @Jefftree |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
LGTM. This means we can remove the etcd 3.7-rc.0 overrides right? Based on this example etcdClusters:
- etcdMembers:
- instanceGroup: master-us-east-1a
name: a
image: gcr.io/etcd-development/etcd:v3.6.99
name: main
version: 3.6.99
- etcdMembers:
- instanceGroup: master-us-east-1a
name: a
image: gcr.io/etcd-development/etcd:v3.6.99
name: events
version: 3.6.99 |
Member
Author
I think so, feel free to /lgtm when ready and you can give it a try afterwards. |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting both version and image on an etcd cluster runs an etcd version that kops does not bundle: the etcd and etcdctl binaries for the given version are sourced from the given image. Both fields must be set together, and only when creating a new etcd cluster; once the cluster exists, the image cannot be added, changed or removed, and the version cannot be changed while an image is set.
With a custom image, only the selected version's binaries are made available to etcd-manager, so restoring backups that require the binaries of a bundled version is not supported.
Also remove the SkipEtcdVersionCheck feature flag: it only skipped the supported-version check and could not make an unbundled version work.
/cc @rifelpet @serathius