Sitelet https://github.com/kubernetes/kops/pull/18522
Skip to content

azure: Scope nodes-to-API NSG rules to the NAT gateway public IP - #18522

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:azure-scope-api-access-v3
Jul 2, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:azure-scope-api-access-v3

Conversation

@hakman

@hakman hakman commented Jul 2, 2026

Copy link
Copy Markdown
Member

The AllowNodesToKubernetesAPI and AllowNodesToKopsController rules allowed any source, which bypassed the spec.api.access allowlist on port 443 and exposed kops-controller to the internet on clusters with a public API load balancer. Node traffic to the public frontend egresses through the NAT gateway, so its public IP is the only source these rules need.

/cc @rifelpet @ameukam

Assisted by Claude Fable

The AllowNodesToKubernetesAPI and AllowNodesToKopsController rules
allowed any source, which bypassed the spec.api.access allowlist on
port 443 and exposed kops-controller to the internet on clusters with
a public API load balancer. Node traffic to the public frontend
egresses through the NAT gateway, so its public IP is the only source
these rules need.
@kubernetes-prow
kubernetes-prow Bot requested review from ameukam and rifelpet July 2, 2026 04:28
@hakman

hakman commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-e2e-azure-cni-cilium

@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2026
@ameukam

ameukam commented Jul 2, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2026
@hakman

hakman commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

/approve

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 4766ce5 into kubernetes:master Jul 2, 2026
28 checks passed
kubernetes-prow Bot added a commit that referenced this pull request Jul 2, 2026
…-upstream-release-1.36

Automated cherry pick of #18522: azure: Scope nodes-to-API NSG rules to the NAT gateway public IP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants