tests/e2e: also skip implement-NodePort ETP=Local test on calico+GCE - #18517
Merged
kubernetes-prow[bot] merged 1 commit intoJun 28, 2026
Merged
Conversation
The "Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes" test fails on calico on GCE but passes on calico on AWS. On GCE the VPC drops packets with arbitrary calico pod-CIDR source/dest addresses, so calico must IPIP-encapsulate inter-node pod traffic (routes go via tunl0). The IPIP/masquerade path rewrites the ETP=Local NodePort traffic's source to the node's tunnel address (a pod-CIDR IP) instead of preserving the client IP. On AWS kops disables the EC2 source/dest check, so calico routes pod traffic natively over the VPC (dev ens5, no encapsulation) and the source IP is preserved. Extend the skip to calico when the cloud provider is GCE. amazon-vpc and kindnet continue running the test on both clouds.
Contributor
|
Skipping CI for Draft Pull Request. |
rifelpet
marked this pull request as ready for review
June 27, 2026 20:45
hakman
approved these changes
Jun 28, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the recent change that runs
Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changeson non-Cilium CNIs (#18515). The test fails on calico on GCE but passes on calico on AWS:100.117.161.64(pod) !=10.0.16.6(node))Root cause
The test runs a hostNetwork pod on node A that curls node B's NodePort with the source bound to node A's IP; with
externalTrafficPolicy=Local, node B must deliver to a local backend without SNAT so the client IP is preserved.... via <nodeIP> **dev tunl0** proto bird onlink... via <nodeIP> **dev ens5** proto birdThe bad source
100.117.161.64is exactly node A's/26IPIP block base (100.117.161.64/26 via 10.0.16.6 dev tunl0) — its tunl0 tunnel address. The IPIP/masquerade path rewrites the source, losing the client IP.kops sets calico to IPIP CrossSubnet on both clouds. The difference:
This is a fundamental calico-IPIP-overlay-on-GCE limitation (same SNAT class as Cilium's overlay), not a kops bug. Corroborated by the rest of the GCE matrix:
ipalias(alias IPs),kindnetandkubenet(GCE routes) all route natively and pass; only the calico overlay fails.Change
Extend the skip to calico when the cloud provider is GCE. amazon-vpc and kindnet keep running the test on both clouds, and calico keeps running it on AWS (where it passes).