tests/e2e: refine externalTrafficPolicy=Local and hostNetwork skips - #18509
Merged
kubernetes-prow[bot] merged 1 commit intoJun 26, 2026
Merged
Conversation
The externalTrafficPolicy=Local source-IP-preservation tests only fail on Cilium (the client IP is SNATed to a pod IP instead of being preserved), tracked upstream in cilium/cilium#37613. Move the "implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes" skip into the Cilium block next to its sibling so other CNIs run the test. The hostNetwork "function for service endpoints" test was fixed in k8s 1.37 by kubernetes/kubernetes#139819 (it now reads spec.nodeName via the Downward API instead of os.Hostname()), so drop its skip gate from < 1.38 to < 1.37. Also clean up stale/incorrect issue references in the surrounding comments (wrong Azure issue, superseded hostname WIP PR, and the unrelated #129221).
Contributor
|
Skipping CI for Draft Pull Request. |
Member
Author
|
/test pull-kops-e2e-k8s-ci |
rifelpet
marked this pull request as ready for review
June 26, 2026 01:24
Member
Author
|
/test pull-kops-e2e-k8s-gce-cilium |
hakman
approved these changes
Jun 26, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified this opportunity for cleanup as a part of kubernetes/test-infra#37337
What
Two corrections to the kubetest2-tester-kops auto skip-regex, plus comment cleanup, based on triage of the (now-removed)
e2e-kops-aws-hostname-bug121018job.1.
externalTrafficPolicy=Localsource-IP tests are Cilium-onlyServices should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changeswas skipped for all CNIs on k8s< 1.38, but it only fails on Cilium — the client source IP is SNATed to a pod IP instead of being preserved (failed every build in the retention window). This is the same root cause as its siblingServices should support externalTrafficPolicy=Local for type=NodePort, which is already Cilium-gated.Moved it into the
networking.Cilium != nilblock next to the sibling so kubenet / kube-router / calico / amazonvpc clusters run the test again. Both now reference the canonical upstream tracker cilium/cilium#37613 (which Cilium's own CI cites to skip the entireexternalTrafficPolicyfamily).2. hostNetwork test was fixed in k8s 1.37
Services should function for service endpoints using hostNetworkwas fixed upstream by kubernetes/kubernetes#139819 (milestone v1.37) — it now readsspec.nodeNamevia the Downward API instead ofos.Hostname(). Dropped its skip gate from< 1.38to< 1.37so 1.37+ runs it.3. Comment cleanup
Removed stale/incorrect issue references: the wrong Azure CSI link (was pointing at an unrelated
kops reconcileissue), the superseded hostname WIP PR #126896, and the unrelated/closed #129221 (a HealthCheckNodePort port-allocation flake, not the current source-IP failure).Behavior changes
< 1.38will now runimplement NodePort and HealthCheckNodePort(assumed Cilium-specific; if it fails on another CNI we re-broaden).1.37will now runfunction for service endpoints using hostNetwork, relying on #139819.