Sitelet https://github.com/kubernetes/kops/pull/18503
Skip to content

scaletest: bind etcd metrics to all interfaces - #18503

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jefftree:scale-etcd-metrics-listen-all
Jun 21, 2026
Merged

scaletest: bind etcd metrics to all interfaces#18503
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jefftree:scale-etcd-metrics-listen-all

Conversation

@Jefftree

@Jefftree Jefftree commented Jun 20, 2026

Copy link
Copy Markdown
Member

Listen on 0.0.0.0 instead of localhost so the in-cluster Prometheus can scrape etcd metrics over the network.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2026
@Jefftree

Jefftree commented Jun 20, 2026

Copy link
Copy Markdown
Member Author

/assign @serathius

Used in conjunction with kubernetes/test-infra#37302

@kubernetes-prow
kubernetes-prow Bot requested review from dims and hakman June 20, 2026 17:17
@serathius

serathius commented Jun 20, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@kubernetes-prow

kubernetes-prow Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@serathius: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius

serathius commented Jun 20, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@kubernetes-prow

kubernetes-prow Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@serathius: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman hakman changed the title scale-test: bind etcd metrics to all interfaces scaletest: bind etcd metrics to all interfaces Jun 21, 2026
@kubernetes-prow kubernetes-prow Bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2026
@serathius

serathius commented Jun 21, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

@kubernetes-prow

kubernetes-prow Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman

hakman commented Jun 21, 2026

Copy link
Copy Markdown
Member

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2026
@hakman

hakman commented Jun 21, 2026

Copy link
Copy Markdown
Member

/unhold

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit c1047de into kubernetes:master Jun 21, 2026
28 checks passed
@Jefftree Jefftree mentioned this pull request Jun 21, 2026
Merged
@Jefftree
Jefftree deleted the scale-etcd-metrics-listen-all branch June 26, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes
@dims dims Awaiting requested review from dims

Assignees

@hakman hakman

@serathius serathius

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jefftree @serathius @hakman