Fixing LB behavior when you have both APIServer and Control Plane. - #18496
Conversation
Initially the LB sent traffic to both. The DNS None is a new case. Now we only send traffic to the APIServer in this case. This protects the Control Plane nodes to do core controller work. Remove separate tests. Regenerated docs.
| } | ||
|
|
||
| func (b *AutoscalingGroupModelBuilder) Build(c *fi.CloudupModelBuilderContext) error { | ||
| clusterHasApiServerOnly := false |
There was a problem hiding this comment.
Nit: clusterHasAPIServerOnlyInstanceGroups
|
Let's get a scenario test going so we can see this working, but .. lgtm. We probably should think about how to roll this out on other clouds also; we could consider creating a shared method like "ShouldAttachAPIServerLoadBalancer" or similar. This is technically a behavioural change, but APIServerNodes is feature flagged and I think it's a good improvement so 👍 Name suggestion is not a blocker /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It is a behavioral change. However it is limited to GCE use cases on as you say a feature flagged use case. |
Initially the LB sent traffic to both.
The DNS None is a new case.
Now we only send traffic to the APIServer in this case.
This protects the Control Plane nodes to do core controller work.