gce: emit kops.k8s.io/instancegroup node label - #18484
Merged
k8s-ci-robot merged 1 commit intoJun 18, 2026
Merged
Conversation
The GCE node identifier reads the instance-group name from the MIG instance template metadata but never adds it to the returned labels, so kops-controller never patches kops.k8s.io/instancegroup onto GCE nodes. The label has been missing since the cluster-api refactor in a7f1b4f.
hakman
approved these changes
Jun 18, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 18, 2026
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 18, 2026
…84-origin-release-1.36 Automated cherry pick of #18484: gce: emit kops.k8s.io/instancegroup node label
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 18, 2026
…84-origin-release-1.35 Automated cherry pick of #18484: gce: emit kops.k8s.io/instancegroup node label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCE node identifier reads the instance-group name from the MIG instance template metadata but never adds it to the returned labels, so kops-controller never patches kops.k8s.io/instancegroup onto GCE nodes. The label has been missing since the cluster-api refactor in a7f1b4f which landed in kops 1.35.
Fixes #18474
assisted by Opus 4.8