Fix kops get assets when spec.dnsZone is a DNS name - #18384
Merged
Merged
Conversation
hakman
force-pushed
the
fix-get-assets
branch
2 times, most recently
from
May 21, 2026 03:22
fe5b3f8 to
e9a3bbd
Compare
Member
Author
|
/test all |
`kops get assets` runs with checkExisting disabled, so DNSZone.Find is skipped and ZoneID is never populated from a DNS-name dnsZone. IAMRolePolicy.ShouldCreate then aborts the run with "DNS ZoneID not set" before assets.Copy is reached. Fall back to DNSName when ZoneID is empty. The rendered policy is discarded in dry-run modes; real applies always populate ZoneID before this path runs. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Member
Author
|
/test pull-kops-e2e-azure-cni-calico |
rifelpet
approved these changes
May 21, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
May 21, 2026
…-upstream-release-1.35 Automated cherry pick of #18384: Fix kops get assets when spec.dnsZone is a DNS name
k8s-ci-robot
added a commit
that referenced
this pull request
May 21, 2026
…-upstream-release-1.34 Automated cherry pick of #18384: Fix kops get assets when spec.dnsZone is a DNS name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kops get assetsruns with checkExisting disabled, so DNSZone.Find is skipped and ZoneID is never populated from a DNS-name dnsZone. IAMRolePolicy.ShouldCreate then aborts the run with "DNS ZoneID not set" before assets.Copy is reached.Fall back to DNSName when ZoneID is empty. The rendered policy is discarded in dry-run modes; real applies always populate ZoneID before this path runs.
Fixes #17713
Fixes #17714
/cc @rifelpet @ameukam