Add excludedInstanceTypes to instanceRequirements - #18113

Hi @jim-barber-he. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

The reason I have raised this PR is because the AWS VPC CNI doesn't work on t2 AWS instances when using Ubuntu 24.04 images.
The networking doesn't seem to come up fully for some reason.
The AWS VPC CNI works on t2 instances when using Ubuntu 22.04 images, but I don't want to have to lock to them forever.

To test I spun up a cluster with the node instance group using this in the spec

  mixedInstancesPolicy:
    instanceRequirements:
      cpu:
        max: "4"
        min: "4"
      excludedInstanceTypes:
        - t2.*
      memory:
        max: "16384M"
        min: "16384M"

The Auto Scaling Group (ASG) in AWS shows this under the Instance type requirements heading of the Details tab:

Then I edited the instance group and changed it to this:

  mixedInstancesPolicy:
    instanceRequirements:
      cpu:
        max: "4"
        min: "4"
      excludedInstanceTypes:
        - t2.*
        - t3.*
      memory:
        max: "16384M"
        min: "16384M"

The kops update cluster shows:

Will modify resources:
  AutoscalingGroup/node.test3.he0.io
        MixedInstanceOverrides   [] -> <nil>
        InstanceRequirements     {"Architecture":null,"CPUMin":4,"CPUMax":4,"MemoryMin":null,"MemoryMax":16384,"ExcludedInstanceTypes":["t2.*"]} -> {"Architecture":null,"CPUMin":4,"CPUMax":4,"MemoryMin":16384,"MemoryMax":16384,"ExcludedInstanceTypes":["t2.*","t3.*"]}

And the result in the ASG is:

Finally I edited the instance group and removed:

      excludedInstanceTypes:
        - t2.*
        - t3.*

The kops update cluster shows:

Will modify resources:
  AutoscalingGroup/node.test3.he0.io
        MixedInstanceOverrides   [] -> <nil>
        InstanceRequirements     {"Architecture":null,"CPUMin":4,"CPUMax":4,"MemoryMin":null,"MemoryMax":16384,"ExcludedInstanceTypes":["t2.*","t3.*"]} -> {"Architecture":null,"CPUMin":4,"CPUMax":4,"MemoryMin":16384,"MemoryMax":16384,"ExcludedInstanceTypes":null}

And the Exclude instances part of the Instance type requirements section of the ASG is no longer showing because there are no instances being excluded anymore.

/ok-to-test

Thanks @jim-barber-he, nice update. If you get a chance could you send another PR to fix the unrelated small bug?
/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Retesting failed PR that otherwise appears ready for merge.

Please help us fix flaky tests by following our Flaky Tests Guide.

Prevent this bot from retesting with /lgtm cancel or /hold.
For this robot's configuration, see here.

/retest-required

Thanks @jim-barber-he, nice update. If you get a chance could you send another PR to fix the unrelated small bug? /lgtm /approve

@hakman Yeah I can raise another PR for that bug.

Now that this PR is merged, do you want me to raise a PR to cherry pick it into the release-1.35 branch so that it ends up in the kOps 1.35.1 release?
Or is that something you'll do anyway?

@hakman Yeah I can raise another PR for that bug.

👍

Now that this PR is merged, do you want me to raise a PR to cherry pick it into the release-1.35 branch so that it ends up in the kOps 1.35.1 release? Or is that something you'll do anyway?

Already done, see #18119.

@hakman The PR to fix the unrelated bug above:
#18123