Fix existing VPCs/Subnets with IPv6 - #18089
Conversation
|
Hi @rlees85. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Thanks @rlees85. Would you mind squashing the commits and using a meaningful commit message? |
a CIDR range associated Signed-off-by: Rich <git0@bitservices.io>
|
Yep my bad, they were pretty bad. Apologies. All done |
|
Thanks @rlees85, LGTM! |
|
/override pull-kops-e2e-k8s-gce-cilium |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
KOPS supports private subnets that are IPv6 only. Unfortunately, the logic when
networkIdis set prevents KOPS from working when any subnet does not havecidrset.See issue: #18078
I could not see any tests for when an existing network is set. I guess because there is no "cloud", for that reason I did not update tests, just ensured existing tests passed.