[aiconformance]: Add accelerator metrics validator test - #18064
Merged
k8s-ci-robot merged 1 commit intoMar 14, 2026
Merged
Conversation
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 13, 2026 18:16
7b953b9 to
e550c77
Compare
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 13, 2026 19:17
e550c77 to
3444b0f
Compare
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 13, 2026 23:44
3444b0f to
1c38cbc
Compare
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
2 times, most recently
from
March 14, 2026 10:21
2f4dfdb to
c18ade7
Compare
Member
Author
|
/test pull-kops-ai-conformance |
1 similar comment
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 14, 2026 15:14
c18ade7 to
c653e73
Compare
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 14, 2026 15:15
c653e73 to
e9264a7
Compare
Member
Author
|
/test pull-kops-ai-conformance |
justinsb
force-pushed
the
aiconformance_accelerator_metrics
branch
from
March 14, 2026 16:19
e9264a7 to
f9d270e
Compare
Member
Author
|
/test pull-kops-ai-conformance |
Member
Author
justinsb
commented
Mar 14, 2026
| var metricClasses map[string]bool | ||
| var metricsOutput string | ||
|
|
||
| // Retry scraping metrics, as the DCGM exporter may not have completed its first collection cycle yet. |
Member
Author
There was a problem hiding this comment.
This retry is why we can't just apply a manifest, BTW. I'll probably extract a helper out for "HTTP GET inside the cluster", but ... starting simple.
Member
|
/lgtm |
hakman
approved these changes
Mar 14, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.