tests/ai-conformance: create cluster with some non-GPU nodes - #18006
Conversation
|
/test pull-kops-ai-conformance |
|
#18005 shows that even without Given GPU nodes are more expensive, I think it makes sense in real environments to have some non-GPU nodes. (And maybe run GPU nodes as-needed). So let's mirror that in this test! |
| metadata: | ||
| name: gpu-nodes | ||
| labels: | ||
| kops.k8s.io/cluster: ${CLUSTER_NAME} |
There was a problem hiding this comment.
This is why we need to make sure that we export CLUSTER_NAME from kubetest2-kops
| if [[ -f "${ENV_FILE}" ]]; then | ||
| # shellcheck disable=SC1090 | ||
| . "${ENV_FILE}" | ||
| export KOPS_STATE_STORE |
There was a problem hiding this comment.
This is a similar fix for when kubetest2-kops generated KOPS_STATE_STORE, but we encountered an error before sourcing it (e.g. in kops validate cluster)
Because GPU nodes are tainted, the cluster won't come up if we don't have any non-GPU nodes. Start the cluster with c5.large nodes, and then add GPU nodes.
9a31f33 to
ddba021
Compare
|
/test pull-kops-ai-conformance |
|
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because GPU nodes are tainted, the cluster won't come up if we
don't have any non-GPU nodes.
Start the cluster with c5.large nodes, and then add GPU nodes.