fix(webhook): generate valid volume name for Prometheus ConfigMap - #3111
Open
rjgoyln wants to merge 1 commit into
Open
fix(webhook): generate valid volume name for Prometheus ConfigMap#3111rjgoyln wants to merge 1 commit into
rjgoyln wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Spark Operator! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
rjgoyln
force-pushed
the
fix/prometheus-configmap-volume-name
branch
from
August 23, 2026 12:13
17729f9 to
3fe1edf
Compare
A SparkApplication name may be up to 63 characters, so appending the Prometheus ConfigMap and volume suffixes overshoots the volume name limit and Kubernetes rejects every driver and executor pod of the application. Signed-off-by: rjgoyln <pt40419@gmail.com>
rjgoyln
force-pushed
the
fix/prometheus-configmap-volume-name
branch
from
August 24, 2026 07:59
3fe1edf to
2281ee4
Compare
rjgoyln
marked this pull request as ready for review
August 24, 2026 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addPrometheusConfigstill derives<configmap name>-vol, the shape #3099 replaced forspec.driver.configMaps. A SparkApplication name only has to be a DNS-1035 label, so once it reaches 50 characters the derived volume name passes 63 and Kubernetes rejects every driver and executor pod of that application. The Prometheus ConfigMap itself stays valid, so nothing catches it earlier.TestGetConfigMapVolumeNamegains the two cases either side of that limit, since today its<=can be flipped to<unnoticed.Closes #3102
Change Category
Checklist
Additional Notes
The
TestPatchSparkPod_PrometheusConfigMapsblock commented out in #2072 sits below the new test and still asserts the old naming. Happy to drop it here.