chore(deps): bump storybook to 9.1.13 DEV-888 - #6080
Closed
magicznyleszek wants to merge 1 commit into
Closed
magicznyleszek wants to merge 1 commit into
magicznyleszek wants to merge 1 commit into
Conversation
magicznyleszek
marked this pull request as ready for review
August 8, 2025 10:01
Akuukis
reviewed
Sep 22, 2025
p2edwards
reviewed
Sep 23, 2025
Comment on lines
+48
to
+50
| # ``` | ||
| # Error: Cannot find module '@biomejs/cli-linux-x64/biome' | ||
| # ``` |
Contributor
There was a problem hiding this comment.
Ah - maybe this bug? npm/cli#4828. Fixed, but not backported, in npm 11. (npm/cli#8184)
Another workaround would be to add this and other packages to our package.json optionalDependencies so they don't get removed again (like this commit odoo/o-spreadsheet@9042443)
(found via https://www.npmjs.com/package/napi-postinstall)
Member
Author
|
As per discussion on standup, @Akuukis will take over this one together with @p2edwards :) Thanks! |
Squashed commit of the following: commit 8835a10 Merge: 425c33a 3a1c852 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Mon Sep 22 16:03:21 2025 +0100 Merge branch 'main' into leszek/bump-storybook-version commit 425c33a Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 16:55:21 2025 +0200 fix types in usage query commit b6cab6e Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 14:34:35 2025 +0200 try bumping tsconfig lib to es2022 commit 2b6a8ec Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 14:28:01 2025 +0200 npm update rebuilt msw-mocks file :+1: commit 29a0019 Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 14:27:44 2025 +0200 biome ignore package.json commit a03e266 Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 13:56:56 2025 +0200 delete unneeded patch commit 595bee4 Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 13:47:39 2025 +0200 rebuild package-lock with "npm update" commit bd02dcc Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 13:40:19 2025 +0200 run biome commit a056520 Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 10:51:22 2025 +0200 biome fixes commit e388567 Author: Leszek <smutnyleszek@gmail.com> Date: Mon Sep 22 10:49:24 2025 +0200 biome missing dep hack commit 0e67d73 Merge: 7d4d222 db47424 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Fri Sep 19 11:57:22 2025 +0100 Merge branch 'main' into leszek/bump-storybook-version commit 7d4d222 Merge: 60170b6 1cdd31f Author: Leszek <smutnyleszek@gmail.com> Date: Wed Sep 17 22:39:43 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 60170b6 Merge: fa60e3f 3ca8946 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Mon Aug 18 10:16:57 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit fa60e3f Merge: f779d34 e2d3329 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Thu Aug 14 10:59:26 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit f779d34 Author: Leszek <smutnyleszek@gmail.com> Date: Tue Aug 12 20:41:45 2025 +0200 add @typescript-eslint/parser commit bcf2565 Author: Leszek <smutnyleszek@gmail.com> Date: Tue Aug 12 20:04:29 2025 +0200 add missing @storybook/types commit 11b9748 Author: Leszek <smutnyleszek@gmail.com> Date: Tue Aug 12 19:15:11 2025 +0200 remove old comment, bump versions again, chane terserplugin setup commit 38ddb86 Merge: 0cd36cb 9c7f6ec Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Tue Aug 12 17:52:39 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 0cd36cb Merge: 43d9254 7d2dd72 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Mon Aug 11 17:27:57 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 43d9254 Merge: 5c4843f 23f7f34 Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Mon Aug 11 11:50:16 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 5c4843f Merge: 687d527 47bc86f Author: Leszek Pietrzak <leszek@magicznyleszek.xyz> Date: Mon Aug 11 11:21:49 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 687d527 Author: Leszek <smutnyleszek@gmail.com> Date: Fri Aug 8 12:09:01 2025 +0200 add missing package commit ec6473d Merge: 83c7394 5b407ec Author: Leszek <smutnyleszek@gmail.com> Date: Fri Aug 8 12:02:13 2025 +0200 Merge branch 'main' into leszek/bump-storybook-version commit 83c7394 Author: Leszek <smutnyleszek@gmail.com> Date: Fri Aug 8 11:52:18 2025 +0200 bump storybook version(s)
Akuukis
force-pushed
the
leszek/bump-storybook-version
branch
from
October 22, 2025 13:05
8835a10 to
c41e8f2
Compare
Akuukis
marked this pull request as draft
October 22, 2025 13:05
Contributor
|
Depends on (at least) bumping react-router first, let's put back to a draft this PR in the meantime. |
Member
Author
Member
Author
|
DEV-888 is "Won't fix" so I'm closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> DEV-1234Front endand/orBack endorworkflow💭 Notes
Updated storybook packages versions with their internal tool.
Also updated
react-refreshand the other refresh package, as I thought it would fix a problem with@storybook/addon-webpack5-compiler-swc. It didn't. But the bump didn't break anything, so I left it there.The
TerserPluginconfiguration in.storybook/main.jswas crashing(npx) storybook buildcommand. I've changed it a bit following some advice online. AFAIK it is not usingswcnow, but it is still helpful 🤷 The previous work here was 19e5a5fAdded
@typescript-eslint/parserbecause eslint complained without it. My guess is that update toeslint-plugin-storybookescalated this requirement 🤷👀 Preview steps
npm installnpm run storybook