fix(securitygroup): deliberately-empty rules list never reaches Available - #965
Merged
Merged
Conversation
…able A SecurityGroup with spec.resource.rules set to an empty list stayed at Available=False forever. ApplyResourceStatus only writes status.resource.rules inside a loop over the OpenStack rules, so an empty group never gets that field, and the old check against orcObject.Status.Resource.Rules could never pass. Compare the rule count against this reconcile's fresh osResource instead, which has no nil-versus-empty ambiguity. Adds a table-driven regression test covering the empty, short, and matching cases. Fixes k-orc#960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SecurityGroup with spec.resource.rules set to an empty list stayed at Available=False forever. ApplyResourceStatus only writes status.resource.rules inside a loop over the OpenStack rules, so an empty group never gets that field, and the old check against orcObject.Status.Resource.Rules could never pass.
Compare the rule count against this reconcile's fresh osResource instead, which has no nil-versus-empty ambiguity. Adds a table-driven regression test covering the empty, short, and matching cases.
Manual backport of #961.