Sitelet https://github.com/jasync-sql/jasync-sql/pull/97
Skip to content

max ttl should not cause query exception if passed, only not given as new connection on take - #97

Merged
oshai merged 2 commits into
masterfrom
maxttl
Feb 21, 2019
Merged

oshai merged 2 commits into
masterfrom
maxttl

Conversation

@oshai

@oshai oshai commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Feb 21, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #97 into master will decrease coverage by 0.01%.
The diff coverage is 73.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #97      +/-   ##
===========================================
- Coverage     77.71%   77.7%   -0.02%     
- Complexity      993     994       +1     
===========================================
  Files           258     258              
  Lines          3653    3655       +2     
  Branches        487     487              
===========================================
+ Hits           2839    2840       +1     
  Misses          573     573              
- Partials        241     242       +1
Impacted Files Coverage Δ Complexity Δ
...github/jasync/sql/db/pool/MaxTtlPassedException.kt 100% <ø> (ø) 1 <0> (ø) ⬇️
...com/github/jasync/sql/db/pool/PoolConfiguration.kt 100% <100%> (ø) 11 <2> (ø) ⬇️
...com/github/jasync/sql/db/ConcreteConnectionBase.kt 100% <100%> (ø) 8 <2> (+1) ⬆️
...ithub/jasync/sql/db/ConnectionPoolConfiguration.kt 64.76% <25%> (ø) 19 <1> (ø) ⬇️
.../github/jasync/sql/db/pool/ActorBasedObjectPool.kt 85.03% <80%> (-0.3%) 18 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8463d...d2f8131. Read the comment docs.

@oshai
oshai merged commit fc9d84d into master Feb 21, 2019
@oshai
oshai deleted the maxttl branch February 21, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant