Repository navigation
Fix MySQL startup in Testcontainers - #357
Merged
Merged
Conversation
KarboniteKream
force-pushed
the
fix/docker-mac
branch
from
January 14, 2023 03:28
f4eb349 to
63bcef1
Compare
KarboniteKream
force-pushed
the
fix/docker-mac
branch
from
January 14, 2023 04:40
0bc675b to
a0d66c5
Compare
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
MySQLContainerconfiguration to have the container successfully start. Testcontainers uses the credentials provided usingwithUsername()andwithPassword()to connect to the container and confirm it has started. With the current implementation ofconfigure(), the state is never correctly set and Testcontainers cannot connect.Detailed changes
configure()so Testcontainers is correctly configuredtestcontainersto latest version, to make it work on M1 Macs (fixes JNA dependency and adds support foramd64images). Closes build(deps): bump testcontainers to 1.17.5 #324..gitignoreto ignore more test logsNotes
The unix socket exposed in #319 does not work correctly under Docker for Mac with VirtioFS enabled, and also prevents container startup due to permission issues. Switching to gRPC FUSE or osxfs is a temporary workaround until it's fixed on Docker side.