Worker options ignore: false and update_duplicates: false cause an error when using postgresql_adapter. - #60
Merged
Merged
Conversation
…an error when using postgresql_adapter.
mberlanda
approved these changes
May 25, 2020
mberlanda
left a comment
Collaborator
There was a problem hiding this comment.
It looks very good! Thank you for the PR.
I will release a minor version by the end of this week! Sounds good to you?
Contributor
Author
|
It sounds wonderful. 😄 |
Collaborator
|
@torce I just released you contribution in v1.8.1! Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQLAdapter#on_conflict_statementreturnsnilwhen both options are false, causing an error when thisnilis appended to the SQL string.Test included in the commit. Standalone script to reproduce the problem: