Sitelet https://github.com/j4mie/paris/pull/128
Skip to content

Allowing IDE autocomplete - #128

Merged
treffynnon merged 1 commit into
j4mie:masterfrom
stratoss:stratoss-patch-1
Mar 21, 2017
Merged

treffynnon merged 1 commit into
j4mie:masterfrom
stratoss:stratoss-patch-1

Conversation

@stratoss

Copy link
Copy Markdown
Contributor

Allowing IDEs to autocomplete when foreach'ing findMany result. Fixes #127

Allowing IDEs to autocomplete when foreach'ing findMany result
@stratoss

Copy link
Copy Markdown
Contributor Author

Huh, any ideas why the tests fail for 7.0 ?

@treffynnon

Copy link
Copy Markdown
Collaborator

Allowing IDEs to autocomplete when foreach'ing findMany result

Looks like a good correction to the code. It doesn't warrant a release in its own right in my opinion so I'll wait to bundle it with any other patches in the future.

Huh, any ideas why the tests fail for 7.0 ?

My guess is because a newer version of PHPUnit is run on the PHP 7 image at Travis CI. One that isn't compatible with the test files in Paris.

@stratoss

Copy link
Copy Markdown
Contributor Author

Thanks @treffynnon . At least with PHPStorm the development experience using Paris is not good without this fix.

@tag tag mentioned this pull request Mar 16, 2017
@stratoss

stratoss commented Mar 17, 2017 •

Copy link
Copy Markdown
Contributor Author

@treffynnon I have a question: Using Paris and PHPStorm how can we enable the autocomplete for model fields? Adding PHPDoc block didn't help, and we can't describe them by creating public $field attributes. Any suggestions?

@tag

tag commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

@stratoss, What do you mean adding PHPDoc block didn't help? (What did you try?). This SO answer suggests a specific docblock that might work.

@treffynnon

treffynnon commented Mar 18, 2017 via email

Copy link
Copy Markdown
Collaborator

@stratoss

stratoss commented Mar 19, 2017 •

Copy link
Copy Markdown
Contributor Author

@treffynnon thank you! Seems that I need to put the PHPDoc block right before the class definition whilst I was creating it in the beginning of the file.

@treffynnon
treffynnon merged commit 4b95407 into j4mie:master Mar 21, 2017
@treffynnon

Copy link
Copy Markdown
Collaborator

I've merged this pull request and fixed the CI failures. Thanks!

@stratoss

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants