fix: make non-superadmins unable to spend without a spend limit - #105
Merged
Merged
Conversation
joshieDo
approved these changes
Apr 8, 2025
joshieDo
added a commit
to ithacaxyz/relay
that referenced
this pull request
Apr 11, 2025
bumps account breaking changes (ithacaxyz/account#105 ithacaxyz/account#108 ithacaxyz/account#106): * super admins cannot have spend permissions set . * P256 cannot be super admins * non-admin keys need to have spend permissions set before they can transact any token. * compensating from a normal key contributes to the spending limit ``` rust /// @dev In order to spend a token, it must have spend permissions set. error NoSpendPermissions(); /// @dev Super admin keys can spend anything. error SuperAdminCanSpendAnything(); /// @dev The `keyType` cannot be super admin. error KeyTypeCannotBeSuperAdmin(); error ExceededSpendLimit(address token); ```
yongkangc
pushed a commit
to ithacaxyz/relay
that referenced
this pull request
Aug 5, 2025
bumps account breaking changes (ithacaxyz/account#105 ithacaxyz/account#108 ithacaxyz/account#106): * super admins cannot have spend permissions set . * P256 cannot be super admins * non-admin keys need to have spend permissions set before they can transact any token. * compensating from a normal key contributes to the spending limit ``` rust /// @dev In order to spend a token, it must have spend permissions set. error NoSpendPermissions(); /// @dev Super admin keys can spend anything. error SuperAdminCanSpendAnything(); /// @dev The `keyType` cannot be super admin. error KeyTypeCannotBeSuperAdmin(); error ExceededSpendLimit(address token); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove tests on set and spend in the same batch. Unable to test this, because once we have added the check to revert when setting spend limits for a super admin, this cannot happen.
non-superadmins cannot spend without a spend limit.