Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
Hi @git-jxj. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Hi @git-jxj. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The
maxConnectionsreference currently mentions HTTP/1 and TCP, suggesting that HTTP/2 connections are excluded. Clarify that HTTP/1.1 and HTTP/2 connections count toward the limit, and link to Envoy's explanation of why the circuit breaker threshold can be exceeded.Regenerate the reference, Go comments, and CRD descriptions. The CRD validation schema is unchanged.
Fixes #3509.
Validation:
make gen,buf lint,make test, and generated HTML checks. The documentation check fails on the original reference and passes after regeneration.