Sitelet https://github.com/ishkawa/APIKit/pull/22
Skip to content

0.7.0 - #22

Merged
ishkawa merged 23 commits into
masterfrom
swift-1.2
Apr 17, 2015
Merged

ishkawa merged 23 commits into
masterfrom
swift-1.2

Conversation

@ishkawa

@ishkawa ishkawa commented Apr 12, 2015

Copy link
Copy Markdown
Owner
  • Support Swift 1.2.
  • Upgrade LlamaKit to 0.6.0
  • Configure API by class var instead of class func (breaking change).

@ishkawa

ishkawa commented Apr 12, 2015

Copy link
Copy Markdown
Owner Author

Tasks runs on CircleCI are suspended for now because it's not ready for Swift 1.2.

Comment thread APIKit/URLEncodedSerialization.swift Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be just bridging (as String), not failable cast.

@ikesyo

ikesyo commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator

I'm sorry for the late response 🙇 Just a few minor comments.

Looks good 👍

@ishkawa

ishkawa commented Apr 17, 2015

Copy link
Copy Markdown
Owner Author

🎉

ishkawa added a commit that referenced this pull request Apr 17, 2015
@ishkawa
ishkawa merged commit b4244ce into master Apr 17, 2015
@ishkawa
ishkawa deleted the swift-1.2 branch April 17, 2015 16:05
@ikesyo

ikesyo commented Apr 17, 2015

Copy link
Copy Markdown
Collaborator

🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants