Repository navigation
clockdiff: Set ppoll timeout minimum to 1ms - #459
Closed
caibingcheng wants to merge 1 commit into
Closed
caibingcheng wants to merge 1 commit into
caibingcheng wants to merge 1 commit into
Conversation
Signed-off-by: caibingcheng <jack_cbc@163.com>
Contributor
|
Sounds reasonable to me. @nmeyerhans WDYT? |
nmeyerhans
approved these changes
May 5, 2023
nmeyerhans
self-requested a review
May 5, 2023 18:10
Contributor
|
Actually, this seems to be fixing the same issue as #380, but with a different approach. Need to look at the two PRs more closely to decide which one is the right approach. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement suggestion.
The ppoll timeout gets dynamically updated while receiving messages. However, if the network environment is good, the timeout gradually decreases to zero, which causes the ppoll to easily timeout and ultimately results in a 'host down' error. To address this, I suggest modifying the code to set the minimum timeout to 1ms. Additionally, by calculating using clockdiff, even in asymmetric network conditions, the error caused by a 1ms timeout would be only 0.5ms, which is lower than the clockdiff precision. Alternatively, a smaller timeout could also be used.