Repository navigation
Conversation
Added ability to execute setcap-setuid.sh on rdisc binary
This was referenced Jul 14, 2021
Closed
pevik
pushed a commit
to pevik/iputils
that referenced
this pull request
Jul 16, 2021
to add ability to execute setcap-setuid.sh on rdisc binary. Closes: iputils#347, iputils#348 Reviewed-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Artur Lebedev <ras_atari@mail.ru>
Contributor
|
@6eh01der While the code is correct, can you explain why this is needed? Most of users nowadays have systemd, thus if they need this legacy software, they run it as a systemd service. Sure, there are few users without systemd, but why don't they run it just as root? |
Contributor
Author
|
@pevik Security. Why to run service as root if it is possible to run it as non-root? By the way systemd service also run as root by default too if no special directives was set like User=, DynamicUser= etc. |
pevik
requested review from
kerolasa,
nmeyerhans and
pevik
and removed request for
pevik
July 20, 2021 19:38
Contributor
Closed
Contributor
Author
|
@pevik Yes, you're right, capabilities could be set by systemd but there is OpenRC for example which is default init system in distros like Alpine, Gentoo and some others. |
pevik
pushed a commit
to pevik/iputils
that referenced
this pull request
Jul 22, 2021
via SETCAP_OR_SUID_RDISC variable. NOTE: This is strongly discouraged as normal uses could possibly modify routing tables, recommended way is to run it as systemd service which does not require it to be enabled. It's added just for non-systemd users, which should run allow it to run just for dedicated user. Closes: iputils#347, iputils#348 Reviewed-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Artur Lebedev <ras_atari@mail.ru> [ Default off, put explanation, rewrite commit message, join commits. ] Signed-off-by: Petr Vorel <pvorel@suse.cz>
pevik
pushed a commit
to pevik/iputils
that referenced
this pull request
Jul 22, 2021
via SETCAP_OR_SUID_RDISC variable. NOTE: This is strongly discouraged as normal uses could possibly modify routing tables, recommended way is to run it as systemd service which does not require it to be enabled. It's added just for non-systemd users, which should run allow it to run just for dedicated user. Closes: iputils#347, iputils#348 Reviewed-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Artur Lebedev <ras_atari@mail.ru> [ Default off, add explanation, fix configure output, rewrite commit message, join commits. ] Signed-off-by: Petr Vorel <pvorel@suse.cz>
Contributor
|
Closed with 2d8d9a4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to execute setcap-setuid.sh on rdisc binary