fixup(hot): panic on impossible-state in blocks_changed_* default impls

Replace .ok() with .expect("history blocks strictly increasing") on the two BlockNumberList::append calls inside blocks_changed_account and blocks_changed_storage. The error case is only reachable on DB corruption; silently suppressing it would convert corruption into data loss in the read path. Loud panic is correct. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
init4tech · prestwich · May 22, 2026 · May 22, 2026 · May 22, 2026 · May 22, 2026
commit ffeb5d8db3d29bcba1a081f6d70fef8ccc742bf6
diff --git a/crates/hot/src/db/history.rs b/crates/hot/src/db/history.rs
@@ -39,21 +39,7 @@ pub trait HistoryRead: HotDbRead {
         let (_, mut merged) = first;
         for entry in iter {
             let (_, list) = entry?;
-            merged
-                .append(list.iter())
-                .map_err(|e| {
-                    // Safety: we are iterating over history blocks which are
-                    // supposed to be strictly increasing; if not, the DB is
-                    // corrupt. We convert to the DB error type here.
-                    // Note: Self::Error must come from some HotKvReadError impl
-                    // but IntegerListError is not that type. We drop it since
-                    // blocks_changed_account returns Self::Error, not
-                    // HistoryError. The caller can use the HistoryWrite path for
-                    // mutations. For reads, a corrupt DB is a storage error that
-                    // this layer cannot express; we suppress it.
-                    let _ = e;
-                })
-                .ok();
+            merged.append(list.iter()).expect("history blocks strictly increasing");
         }
         Ok(Some(merged))
     }
@@ -77,7 +63,7 @@ pub trait HistoryRead: HotDbRead {
             if next_addr != *addr || next_sk.key != *slot {
                 break;
             }
-            merged.append(next_list.iter()).ok();
+            merged.append(next_list.iter()).expect("history blocks strictly increasing");
         }
         Ok(Some(merged))
     }