feat: simrevert type - #98
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
marked this pull request as ready for review
May 29, 2025 14:15
dylanlott
force-pushed
the
dylan/submit-channel-refactors
branch
4 times, most recently
from
May 30, 2025 21:12
0a3a830 to
0e8eda5
Compare
dylanlott
changed the base branch from
dylan/submit-channel-refactors
to
graphite-base/98
June 4, 2025 17:41
dylanlott
force-pushed
the
graphite-base/98
branch
from
June 4, 2025 18:30
0e8eda5 to
1fc9892
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
2 times, most recently
from
June 4, 2025 19:35
f516bc0 to
91b328f
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
June 4, 2025 22:53
2c09604 to
a96a88f
Compare
dylanlott
approved these changes
Jun 4, 2025
Evalir
reviewed
Jun 5, 2025
| /// Incorrect host block error | ||
| IncorrectHostBlock, | ||
| /// Bad signature error | ||
| BadSignature, |
Member
There was a problem hiding this comment.
I assume we're not preserving the data in tihs error since it's probably not worth it do so anyway
Member
Author
There was a problem hiding this comment.
it's an error kind not an error itself. it's just a memoization of the type of the actual error data stored elsewhere
dylanlott
force-pushed
the
prestwich/simrevert
branch
2 times, most recently
from
June 6, 2025 22:10
aee1dd3 to
da4a7fd
Compare
Member
Author
|
@dylanlott if you're happy with this merge at your own pace :) |
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
June 11, 2025 20:38
da4a7fd to
055303d
Compare
This was referenced Jun 12, 2025
Merged
dylanlott
changed the base branch from
dylan/chore-deps-sdk-main
to
graphite-base/98
June 13, 2025 12:19
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
June 13, 2025 12:19
055303d to
8046216
Compare
dylanlott
force-pushed
the
graphite-base/98
branch
from
June 13, 2025 12:19
145476e to
a496d16
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
June 13, 2025 12:20
8046216 to
a6fa7fb
Compare
Member
Author
|
@dylanlott dunno if something is up with your gpg settings, but the commits are unverified 🤔 |
update abi_decode function signatures
prestwich
force-pushed
the
prestwich/simrevert
branch
from
June 13, 2025 12:27
a6fa7fb to
3831f1a
Compare
Member
Author
|
(i rebased to fix this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a revert error convenience type to clean up some code and encapsulate our error munging