refactor: encapsulate prep and bump logic - #107
Merged
Merged
Conversation
Member
Author
prestwich
marked this pull request as ready for review
June 13, 2025 15:17
dylanlott
force-pushed
the
prestwich/some-cleaning-submit
branch
from
June 13, 2025 23:55
56cb4d0 to
628ae83
Compare
dylanlott
force-pushed
the
prestwich/bumpable-prep
branch
from
June 13, 2025 23:55
491b9cd to
0d88be1
Compare
This was referenced Jun 13, 2025
Merged
dylanlott
force-pushed
the
prestwich/some-cleaning-submit
branch
from
June 14, 2025 00:10
628ae83 to
b5082b8
Compare
dylanlott
force-pushed
the
prestwich/bumpable-prep
branch
3 times, most recently
from
June 14, 2025 02:35
4f0445e to
ecc8355
Compare
dylanlott
reviewed
Jun 14, 2025
|
|
||
| let blob_basefee = prev_header | ||
| .next_block_blob_fee(BlobParams::prague()) | ||
| .expect("signet deployed after 4844 active"); |
Contributor
There was a problem hiding this comment.
So, this expect was panicking at runtime. I updated it to an unwrap_or and it defaults to the Prague value, but I'm not sure why it was panicking.
dylanlott
approved these changes
Jun 14, 2025
dylanlott
left a comment
Contributor
There was a problem hiding this comment.
Tested and working in dev-net with the commits that patch the expect issue. Approving to unblock.
Evalir
changed the base branch from
prestwich/some-cleaning-submit
to
graphite-base/107
June 16, 2025 14:35
Evalir
force-pushed
the
graphite-base/107
branch
from
June 16, 2025 14:35
3265307 to
da4dd57
Compare
Evalir
force-pushed
the
prestwich/bumpable-prep
branch
from
June 16, 2025 14:35
f6fb01d to
7e925ff
Compare
Evalir
changed the base branch from
graphite-base/107
to
prestwich/some-cleaning-submit_split
June 16, 2025 14:35
Evalir
changed the base branch from
prestwich/some-cleaning-submit_split
to
graphite-base/107
June 16, 2025 14:41
Evalir
force-pushed
the
prestwich/bumpable-prep
branch
from
June 16, 2025 14:41
d02b77e to
244f70d
Compare
Evalir
force-pushed
the
graphite-base/107
branch
from
June 16, 2025 14:41
da4dd57 to
e1f2221
Compare
Evalir
force-pushed
the
prestwich/bumpable-prep
branch
from
June 16, 2025 14:42
244f70d to
c3d8590
Compare
Evalir
approved these changes
Jun 16, 2025
| ControlFlow::Retry => { | ||
| // bump the req | ||
| req = bumpable.bumped(); | ||
| if bumpable.bump_count() > retry_limit { |
Member
There was a problem hiding this comment.
this comparison means that we send a TX at most 1 + RETRY_LIMIT times. Usually retries include the first time a tx is sent, but i'm fine with it not being included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulate logic for the following processes:
So that they are out of the main retrying loop
Closes ENG-1084