Sitelet https://github.com/import-js/eslint-plugin-import/pull/508
Skip to content

Fix false positive with default import having a "default" property - #508

Closed
jquense wants to merge 1 commit into
import-js:masterfrom
jquense:fix-507
Closed

jquense wants to merge 1 commit into
import-js:masterfrom
jquense:fix-507

Conversation

@jquense

@jquense jquense commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Fixes #507

@coveralls

coveralls commented Aug 22, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 97.726% when pulling 084d229 on jquense:fix-507 into 7995581 on benmosher:master.

@jfmengels

Copy link
Copy Markdown
Collaborator

LGTM, thanks @jquense :)

@benmosher benmosher closed this in 0d98253 Aug 23, 2016
@benmosher benmosher added this to the 1.15.0 milestone Aug 23, 2016
@benmosher

Copy link
Copy Markdown
Member

Indeed, thanks much for a high-quality PR! 😎

@jfmengels

jfmengels commented Aug 23, 2016 •

Copy link
Copy Markdown
Collaborator

Only thing missing was adding thanks to yourself in the changelog, but we'll do that next time we update it 😄
(and also link to this PR in the changelog)
Thanks again!

@benmosher

Copy link
Copy Markdown
Member

@jfmengels I got it in the rebase: 0d98253#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR11 😁

Can't really blame folks for not wanting to thank themselves, I suppose... 😄

@jfmengels

Copy link
Copy Markdown
Collaborator

Truthfylly, I think it's odd to ask someone to thank themselves or add themselves to a contributors list. It's better done by the maintainers to show that your work is really appreciated :)

Btw, do you want to add a link to this PR in the changelog?

@jquense

jquense commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

thanks y'all!

@benmosher

Copy link
Copy Markdown
Member

@jfmengels maybe we should start doing the changelog update in the merge commit instead of the PR. that would be less merge-conflict-prone, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants