Conversation
|
LGTM, thanks @jquense :) |
|
Indeed, thanks much for a high-quality PR! 😎 |
|
Only thing missing was adding thanks to yourself in the changelog, but we'll do that next time we update it 😄 |
|
@jfmengels I got it in the rebase: 0d98253#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR11 😁 Can't really blame folks for not wanting to thank themselves, I suppose... 😄 |
|
Truthfylly, I think it's odd to ask someone to thank themselves or add themselves to a contributors list. It's better done by the maintainers to show that your work is really appreciated :) Btw, do you want to add a link to this PR in the changelog? |
|
thanks y'all! |
|
@jfmengels maybe we should start doing the changelog update in the merge commit instead of the PR. that would be less merge-conflict-prone, too. |
Fixes #507