Sitelet https://github.com/import-js/eslint-plugin-import/pull/499
Skip to content

Fix namespace rule runtime crash - #499

Merged
benmosher merged 3 commits into
import-js:masterfrom
wKich:commonjs-namespace
Aug 18, 2016
Merged

benmosher merged 3 commits into
import-js:masterfrom
wKich:commonjs-namespace

Conversation

@wKich

@wKich wKich commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Aug 16, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 97.667% when pulling 69a1dec on wKich:commonjs-namespace into 90dedd7 on benmosher:master.

@coveralls

coveralls commented Aug 16, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 97.669% when pulling 8171db3 on wKich:commonjs-namespace into 90dedd7 on benmosher:master.

@benmosher

Copy link
Copy Markdown
Member

this fixes #416, yeah? or did you find and fix independently?

@benmosher

Copy link
Copy Markdown
Member

also: thanks! 😄 can you add a changelog note?

@wKich

wKich commented Aug 17, 2016

Copy link
Copy Markdown
Contributor Author

@benmosher, sure. I found it while working in my own project.

@coveralls

coveralls commented Aug 17, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 97.669% when pulling bbeb404 on wKich:commonjs-namespace into 90dedd7 on benmosher:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.004%) to 97.669% when pulling bbeb404 on wKich:commonjs-namespace into 90dedd7 on benmosher:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants