Sitelet https://github.com/import-js/eslint-plugin-import/pull/359
Skip to content

prefer-default-export: Support 'export function foo() {}; export const x = 4;' - #359

Merged
benmosher merged 2 commits into
import-js:masterfrom
scottnonnenberg:fix-export-function
May 31, 2016
Merged

benmosher merged 2 commits into
import-js:masterfrom
scottnonnenberg:fix-export-function

Conversation

@scottnonnenberg

Copy link
Copy Markdown
Contributor

Fixes #358.

The fixes to support multiple declarations left out a crucial else case.

@gavriguy

Copy link
Copy Markdown
Contributor

LGTM

@benmosher

Copy link
Copy Markdown
Member

Great catch!

Can you make a change log note?

@scottnonnenberg

Copy link
Copy Markdown
Contributor Author

Hopefully that's what you're looking for! :0)

@benmosher
benmosher merged commit 92f7d65 into import-js:master May 31, 2016
silverwind pushed a commit to silverwind/eslint-plugin-import that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

prefer-default-export doesn't count 'export function foo() {}'

3 participants