Conversation
Contributor
Author
|
The travis ci build failed because |
Member
|
Thanks! 😄 |
Contributor
|
Nice, thanks! |
|
I encountered alike problem on import type { Connector } from 'react-redux'
|
|
:/ import defaultNamed, { named, typed namedType } from './module';This is fine as the default, but it would be nice to provide an option to keep the previous behavior. |
3 tasks
AntonioVentilii
added a commit
to dfinity/eslint-config-oisy-wallet
that referenced
this pull request
Feb 23, 2026
# Motivation We can use the eslint rule `no-duplicate-imports` instead of [no-duplicate](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md): > ESLint core has a similar rule ([no-duplicate-imports](https://eslint.org/docs/rules/no-duplicate-imports)), but this version is different in two key ways: > > 1. the paths in the source code don't have to exactly match, they just have to point to the same module on the filesystem. (i.e. ./foo and ./foo.js) > 2. this version distinguishes Flow type imports from standard imports. (import-js/eslint-plugin-import#334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #225
If import is a flow
typeimport, add to separate map for duplicate checking.