[Fix] no-duplicates: preserve default imports with comments - #3289
Open
ZelinZhu-Richard wants to merge 2 commits into
Open
ZelinZhu-Richard wants to merge 2 commits into
ZelinZhu-Richard wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
=======================================
Coverage 79.59% 79.60%
=======================================
Files 98 98
Lines 4549 4550 +1
Branches 1543 1576 +33
=======================================
+ Hits 3621 3622 +1
Misses 928 928 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-duplicatescan produce an invalid duplicate declaration when a comment prevents an import from being removed:The fixer copies
EmberObjectinto the first import while leaving the second import intact. Only copy a default binding from an import eligible for removal, using the same filtered set as the removal logic. Existing ambiguity checks and comment handling stay unchanged; other safe imports can still merge.Addresses the invalid-autofix part of #1838; merging across comments is intentionally left unfixed.
Tested:
tests/src/rules/no-duplicates.js: 114 passed. Regression coverage includes the reported example, leading/trailing/internal comments, and merging a third safe import. Five added cases failed before the fix; existing ambiguity and ordinary default-import cases pass.npm test: 3,151 passed, 2 pending, including lint and documentation checks.AI assistance: this change was developed with an AI coding tool; I reviewed and tested it.