Sitelet https://github.com/import-js/eslint-plugin-import/pull/254
Skip to content

Consider also resolve.fallback while resolving modules with webpack - #254

Merged
benmosher merged 5 commits into
import-js:masterfrom
yp:master
Apr 22, 2016
Merged

benmosher merged 5 commits into
import-js:masterfrom
yp:master

Conversation

@yp

@yp yp commented Apr 22, 2016

Copy link
Copy Markdown
Contributor

Add resolve.fallback to the paths used to resolve modules in webpack.

@benmosher

Copy link
Copy Markdown
Member

Sweet, thanks! I wondered when this would come up. Thanks for skipping the issue and going straight for the PR! 😎

Can you add a note in the change log with a reference to this PR?

@yp

yp commented Apr 22, 2016

Copy link
Copy Markdown
Contributor Author

For sure!
I'll add the note right now.

@benmosher

benmosher commented Apr 22, 2016 •

Copy link
Copy Markdown
Member

There is a section of PR url definitions at the bottom, can you dupe the top one and update to 254?

https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md#L148

@benmosher

Copy link
Copy Markdown
Member

Fantastic, thanks!

@benmosher
benmosher merged commit d6b0ef6 into import-js:master Apr 22, 2016
stephenjason89 pushed a commit to stephenjason89/eslint-plugin-import that referenced this pull request May 17, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants