Sitelet https://github.com/import-js/eslint-plugin-import/pull/2212
Skip to content

[New] no-unused-modules: support dynamic imports [2] - #2212

Merged
ljharb merged 2 commits into
import-js:mainfrom
Hypnosphi:no-unused-modules-dynamic-imports
Sep 15, 2021
Merged

[New] no-unused-modules: support dynamic imports [2]#2212
ljharb merged 2 commits into
import-js:mainfrom
Hypnosphi:no-unused-modules-dynamic-imports

Conversation

@Hypnosphi

@Hypnosphi Hypnosphi commented Aug 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replaces #1660

maxkomarychev and others added 2 commits June 20, 2020 15:10
@maxkomarychev @Hypnosphi
@aladdin-add @ljharb
[utils] [new] add visit, to support dynamic imports
7579748 
See import-js#1660, import-js#2212.

Co-authored-by: Max Komarychev <maxkomarychev@gmail.com>
Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com>
Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>
@maxkomarychev @Hypnosphi
@aladdin-add @ljharb
[New] no-unused-modules: support dynamic imports
7c382f0 
All occurences of `import('...')` are treated as namespace imports
(`import * as X from '...'`)

See import-js#1660, import-js#2212.

Co-authored-by: Max Komarychev <maxkomarychev@gmail.com>
Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com>
Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>
@Hypnosphi
Hypnosphi force-pushed the no-unused-modules-dynamic-imports branch from e69c056 to 86a87d3 Compare August 30, 2021 17:03
@ljharb

ljharb commented Aug 30, 2021

Copy link
Copy Markdown
Member

oof, please don't make new PRs (but please leave this one open, since now I have to keep it in sync with #1660 until both are merged)

@ljharb
ljharb marked this pull request as draft August 30, 2021 17:09
@Hypnosphi

Hypnosphi commented Aug 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry, the scheme with two branches for one PR apparently didn't work well, at least for me. Tests are passing in my branch, I have no idea what broke them in the original branch

@ljharb

ljharb commented Aug 30, 2021

Copy link
Copy Markdown
Member

Probably something that landed in master in the interim, since the branches shouldn't be any different.

@Hypnosphi

Hypnosphi commented Aug 30, 2021

Copy link
Copy Markdown
Contributor Author

My branch is up-to date with master

@Hypnosphi
Hypnosphi force-pushed the no-unused-modules-dynamic-imports branch 2 times, most recently from 63c3c5a to b724db8 Compare August 30, 2021 17:37
@Hypnosphi

Hypnosphi commented Aug 30, 2021

Copy link
Copy Markdown
Contributor Author

All green now

ljharb
ljharb reviewed Aug 30, 2021
View reviewed changes
Comment thread .github/workflows/node-4+.yml
ljharb pushed a commit to ljharb/eslint-plugin-import that referenced this pull request Aug 30, 2021
@Hypnosphi @ljharb
[Tests] run pretest on CI
397b6c5 
Extracted from import-js#2212 / import-js#1660.
@Hypnosphi Hypnosphi changed the title [New] no-unused-modules: support dynamic imports [New] no-unused-modules: support dynamic imports [2] Aug 30, 2021
@ljharb
ljharb force-pushed the no-unused-modules-dynamic-imports branch 2 times, most recently from 329454c to 3d8cc76 Compare September 1, 2021 02:14
@ljharb

ljharb commented Sep 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

post rebase, travis-ci is failing, with Error: Cannot find module 'eslint-module-utils/visit' - despite 968dda1 (which wasn't required for travis tests to be passing before)

@codecov

codecov Bot commented Sep 1, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2212 (968dda1) into main (35bd977) will decrease coverage by 1.12%.
The diff coverage is n/a.

❗ Current head 968dda1 differs from pull request most recent head 7c382f0. Consider uploading reports for the commit 7c382f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   84.28%   83.16%   -1.13%     
==========================================
  Files          93       93              
  Lines        2971     2987      +16     
  Branches      881      879       -2     
==========================================
- Hits         2504     2484      -20     
- Misses        467      503      +36
Impacted Files Coverage Δ
utils/declaredScope.js 83.33% <0.00%> (-16.67%) ⬇️
utils/parse.js 71.79% <0.00%> (-15.71%) ⬇️
utils/hash.js 85.29% <0.00%> (-14.71%) ⬇️
utils/module-require.js 87.50% <0.00%> (-12.50%) ⬇️
utils/ModuleCache.js 90.00% <0.00%> (-10.00%) ⬇️
utils/ignore.js 87.50% <0.00%> (-9.06%) ⬇️
utils/moduleVisitor.js 91.80% <0.00%> (-8.20%) ⬇️
utils/resolve.js 92.91% <0.00%> (-7.09%) ⬇️
resolvers/node/index.js 91.42% <0.00%> (-5.55%) ⬇️
src/rules/no-unresolved.js 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bd977...7c382f0. Read the comment docs.

@Hypnosphi

Hypnosphi commented Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

For some reason, I don't see npm run pretest in the job log: https://app.travis-ci.com/github/import-js/eslint-plugin-import/jobs/534928091

@ljharb

ljharb commented Sep 1, 2021

Copy link
Copy Markdown
Member

hm, you're right, i don't see that either. Maybe after_install isn't a thing, i'll fix that.

@ljharb
ljharb force-pushed the no-unused-modules-dynamic-imports branch from 3d8cc76 to b0acc6e Compare September 1, 2021 14:18
@ljharb
ljharb force-pushed the no-unused-modules-dynamic-imports branch from b0acc6e to b7bf750 Compare September 14, 2021 23:29
@ljharb
ljharb marked this pull request as ready for review September 14, 2021 23:30
@ljharb
ljharb force-pushed the no-unused-modules-dynamic-imports branch from b7bf750 to 7c382f0 Compare September 14, 2021 23:34
@ljharb
ljharb merged commit 7c382f0 into import-js:main Sep 15, 2021
@aladdin-add

aladdin-add commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

👍 awesome! thx for fixing this!

@Meemaw

Meemaw commented Sep 22, 2021

Copy link
Copy Markdown

Hey, is it possible to release this? 🙏

@danielbachhuber danielbachhuber mentioned this pull request Oct 13, 2021
Merged
@sync-by-unito sync-by-unito Bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Dec 1, 2021
Closed
This was referenced Dec 31, 2021
Merged
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Feb 1, 2022
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hypnosphi @ljharb @aladdin-add @Meemaw @maxkomarychev