[Fix] no-restricted-paths: false-positive matches - #2090
Merged
Merged
Conversation
no-restricted-paths: partial paths false-positive matches
malykhinvi
marked this pull request as ready for review
May 18, 2021 13:21
no-restricted-paths: partial paths false-positive matchesno-restricted-paths: false-positive matches
ljharb
approved these changes
May 18, 2021
ljharb
left a comment
Member
There was a problem hiding this comment.
Thanks, this is great. Normally I firmly believe that more deps is better, but I'm stoked to remove this particular dep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2089
In this PR I removed
contains-pathsdependency and used node'spath.relativeto identify if a file is inside thetarget. I used an approach similar to the one used insrc/core/importType