[Fix] no-named-default: ignore Flow import type and typeof - #1983
Merged
Merged
Conversation
christianvuerings
force-pushed
the
no-named-default-flow
branch
from
February 1, 2021 16:13
0709fa9 to
3f171f7
Compare
ljharb
approved these changes
Feb 1, 2021
ljharb
force-pushed
the
no-named-default-flow
branch
from
February 1, 2021 16:46
3f171f7 to
4c92c47
Compare
no-named-default: ignore Flow import type and typeofno-named-default: ignore Flow import type and typeof
Contributor
Author
|
@ljharb Thanks for the quick merge! Do you know when we could release the next version of |
Member
|
@christianvuerings there's no planned timeline. generally it's a few months between releases, so we're coming due for one. |
Contributor
Author
@ljharb should I follow the steps in RELEASE.md to get a release cut? I can do everything until step 4. |
Member
|
@christianvuerings no, master’s broken right now. See #1986. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Syncs the behavior of
no-named-defaultwithnamed, which also ignores Flow imports & exports:Without this fix,
no-named-defaultconflicts with theflowtype/type-import-stylerule with a default setting of "identifier".Issue
"Identifier syntax":
Gives following error:
Whilst the "declaration syntax":
Generates no error.
Related PRs / Issues
named: ignore Flow import typeof and export type #1345: [fix]named: ignore Flow import typeof and export type