[Refactor] no-extraneous-dependencies: use moduleVisitor - #1735
Conversation
ljharb
left a comment
There was a problem hiding this comment.
@adamborowski hi! sorry for the delay :-)
This looks great! Are there any additional test cases that would now pass, but would have failed before, that we could also add in this PR?
|
I don't think so, this is just refactoring. I will add several PRs with tests from our forked rule that we really miss. |
|
Thanks! I can merge it now without them, since existing tests pass, but more test cases are always appreciated, so I'll wait for those if you're OK with that :-) |
|
I think for this particular PR there is no more cases. |
|
@adamborowski can you please check "allow edits" on the RHS of the PR? also, there's a github bug where PRs from forks that aren't your own (CloudinaryLtd vs adamborowski) won't grant the permission properly, so I'll need you to add me to that fork so I can force push to the PR branch. Thanks! |
|
Added. There is no option to allow edit on the right side |
|
Interesting, maybe they "fixed" their bug by hiding the checkbox in those cases :-p Thanks, I should be able to land this shortly. |
no-extraneous-dependencies: use moduleVisitor
Hi.
I start with simple refactoring but I already have few suggestions with code changes and tests that will make no-extraneous-dependencies more flexible for monorepo projects.
This PR is a warmup. I'd like to see if our interaction goes well.
I hope you will enjoy my contribution.
Cheers,
Adam