[fix] order: recognize ".." as a "parent" path - #1658
Merged
Merged
Conversation
3 similar comments
ljharb
force-pushed
the
order-dot-dot
branch
from
February 17, 2020 08:24
6aa3c2c to
12971f5
Compare
ljharb
reviewed
Feb 17, 2020
ljharb
left a comment
Member
There was a problem hiding this comment.
Per #1405 (comment), should this go through the resolver to consider "parent"-ness?
Contributor
Author
I believe it is better to order the import statements by the apparent path rather the resolved path. What I wanted for this rule is a consistent ordering that looks nice. Ordering by resolved path does not provide a consistent ordering that looks nice. |
Member
|
True, that makes sense. |
ljharb
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1405