Sitelet https://github.com/import-js/eslint-plugin-import/pull/1572
Skip to content

[extensions] Ignore query strings when checking for extensions. - #1572

Merged
ljharb merged 1 commit into
import-js:masterfrom
pcorpet:query-string-extension
Jan 1, 2020
Merged

[extensions] Ignore query strings when checking for extensions.#1572
ljharb merged 1 commit into
import-js:masterfrom
pcorpet:query-string-extension

Conversation

@pcorpet

@pcorpet pcorpet commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

Fixes #1567.

@coveralls

coveralls commented Dec 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 96.176% when pulling 982493d on pcorpet:query-string-extension into b791ba5 on benmosher:master.

@coveralls

coveralls commented Dec 15, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

3 similar comments
@coveralls

coveralls commented Dec 15, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls

coveralls commented Dec 15, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls

coveralls commented Dec 15, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

ljharb
ljharb approved these changes Jan 1, 2020
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Comment thread src/rules/extensions.js Outdated
Comment thread src/rules/extensions.js Outdated
@ljharb
ljharb force-pushed the query-string-extension branch from 864d99c to 982493d Compare January 1, 2020 22:12
@ljharb
ljharb merged commit 982493d into import-js:master Jan 1, 2020
@ljharb ljharb mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[extensions] Alerting on missing extension when using query string

3 participants

@pcorpet @coveralls @ljharb