Sitelet https://github.com/import-js/eslint-plugin-import/pull/1435
Skip to content

feat: support parseForESLint from custom parser - #1435

Merged
ljharb merged 1 commit into
import-js:masterfrom
JounQin:feat/parse_for_eslint
Aug 5, 2019
Merged

feat: support parseForESLint from custom parser#1435
ljharb merged 1 commit into
import-js:masterfrom
JounQin:feat/parse_for_eslint

Conversation

@JounQin

@JounQin JounQin commented Aug 3, 2019

Copy link
Copy Markdown
Collaborator

close #1433

@JounQin JounQin mentioned this pull request Aug 3, 2019
Closed
@coveralls

coveralls commented Aug 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.6%) to 97.897% when pulling 35a12f9 on JounQin:feat/parse_for_eslint into ebcf17c on benmosher:master.

@coveralls

coveralls commented Aug 3, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

1 similar comment
@coveralls

coveralls commented Aug 3, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

@cdfa

cdfa commented Aug 3, 2019

Copy link
Copy Markdown

So I ran npm i -D JounQin/eslint-plugin-import#feat/parse_for_eslint, but it's not working. I looked for the utlis/parse.js file you modified and it seems to be located at node_modules/eslint-module-utils/parse.js, but it doesn't have your patch. How do I test it?

@JounQin

JounQin commented Aug 3, 2019

Copy link
Copy Markdown
Collaborator Author

@cdfa There is no need to wait for this PR, I've exported parse from @rxts/eslint-plugin-mdx, you can simply upgrade to the latest version.

@cdfa

cdfa commented Aug 3, 2019

Copy link
Copy Markdown

Ah great!

ljharb
ljharb reviewed Aug 3, 2019
View reviewed changes
Comment thread tests/src/core/parse.js Outdated
Comment thread utils/parse.js Outdated
ljharb
ljharb reviewed Aug 5, 2019
View reviewed changes
Comment thread tests/src/core/parse.js
ljharb
ljharb approved these changes Aug 5, 2019
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb
ljharb merged commit 35a12f9 into import-js:master Aug 5, 2019
@JounQin
JounQin deleted the feat/parse_for_eslint branch August 5, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

semver-minor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parse error in mdx files

4 participants

@JounQin @coveralls @cdfa @ljharb