Sitelet https://github.com/import-js/eslint-plugin-import/pull/1404
Skip to content

Exclude pkg main files from no-unused-modules - #1404

Merged
ljharb merged 1 commit into
import-js:masterfrom
rfermann:master
Jul 17, 2019
Merged

ljharb merged 1 commit into
import-js:masterfrom
rfermann:master

Conversation

@rfermann

@rfermann rfermann commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Implements a solution for #1327

@coveralls

coveralls commented Jul 2, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 97.992% when pulling 1caa402 on rfermann:master into 22d5440 on benmosher:master.

Comment thread docs/rules/no-unused-modules.md Outdated
Comment thread src/rules/no-unused-modules.js
Comment thread src/rules/no-unused-modules.js Outdated
Comment thread src/rules/no-unused-modules.js Outdated

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just a couple more changes.

Comment thread docs/rules/no-unused-modules.md Outdated
Comment thread tests/files/no-unused-modules/main/index.js Outdated
Comment thread src/rules/no-unused-modules.js Outdated
Comment thread src/rules/no-unused-modules.js Outdated
@ljharb
ljharb force-pushed the master branch 2 times, most recently from ef3b84e to 1caa402 Compare July 17, 2019 21:55
@ljharb
ljharb merged commit 1caa402 into import-js:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants