Support ESLint v6 by sheepsteak · Pull Request #1393 · import-js/eslint-plugin-import

sheepsteak · 2019-06-23T19:12:19Z

The main issues are:

Use require.resolve when passing the parser option to RuleTester (https://eslint.org/docs/user-guide/migrating-to-6.0.0#rule-tester-parser)
Add ecmaVersion when sourceType is module (https://eslint.org/docs/user-guide/migrating-to-6.0.0#-the-default-parser-now-validates-options-more-strictly)
Transform output of the FileEnumerator into what the import/no-unused-modules rule expects
@typescript-eslint/parser is using an internal module (eslint/lib/util/traverser) which has been removed in ESLint@6 and therefore causing an error. It's been fixed in fix(parser): add simpleTraverse, replaces private ESLint util typescript-eslint/typescript-eslint#628 but not been released yet. (Updated to canary, thanks @golopot)
Same as above for typescript-eslint-parser but this is an archived package. As I write this I realise I should probably use the testVersion function so that tests for this are skipped on eslint>=6

To test:

npm i eslint@6
npm test

The only failing tests should be related to the TypeScript issue above.

Related to airbnb/javascript#2036.
Fixes #1362.

sheepsteak · 2019-06-23T19:20:39Z

It's also having some sort of whitespace issue with a couple of tests as you can see here - https://ci.appveyor.com/project/benmosher/eslint-plugin-import/builds/25480510/job/i7a5k9x6j6s1hg8a#L3072. I think I've fixed it and then it comes back again haha

coveralls · 2019-06-23T19:37:05Z

Coverage remained the same at 97.803% when pulling c61fad0 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

coveralls · 2019-06-23T19:37:07Z

Coverage remained the same at 97.803% when pulling c61fad0 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

coveralls · 2019-06-23T19:37:07Z

Coverage increased (+0.1%) to 97.953% when pulling 7e41d29 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

coveralls · 2019-06-23T19:37:08Z

Coverage remained the same at 97.803% when pulling c61fad0 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

coveralls · 2019-06-23T19:37:08Z

Coverage remained the same at 97.803% when pulling c61fad0 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

coveralls · 2019-06-23T19:37:08Z

Coverage remained the same at 97.803% when pulling c61fad0 on sheepsteak:eslint-6 into fc65509 on benmosher:master.

ljharb

It seems like you made a bunch of unrelated formatting changes; please revert them.

ljharb · 2019-06-23T20:28:45Z

Are you perhaps running prettier on autosave in your editor or something? If so, disable that - prettier should only be run via eslint autofix, and only on repos that use it.

ljharb · 2019-06-23T21:38:09Z

  listFilesToProcess = function (src) {
    var e = new FileEnumerator()
-    return Array.from(e.iterateFiles(src))
+    return Array.from(e.iterateFiles(src), ({ filePath, ignored })=>({


Suggested change

return Array.from(e.iterateFiles(src), ({ filePath, ignored })=>({

return Array.from(e.iterateFiles(src), ({ filePath, ignored }) => ({

sheepsteak · 2019-06-23T21:46:12Z

Sorry about the double quote changes. I've reverted all of them. I have Prettier set to only work when there is a .prettierrc present so I'm not sure what's causing that 🤷‍♂️

chiawendt · 2019-06-23T21:51:39Z

I suppose it is eslint in your editor doing that changes. The ci does not lint over ./tests, so there are many lines in ./tests not passing eslint.

sheepsteak · 2019-06-23T22:06:18Z

Added a commit to only run tests for typescript-eslint-parser when ESLint is <6 where appropriate given that it's archived and will probably never get the required fix.

Would you like me to update Travis CI config to use 6.0.0 instead of 6.0.0-alpha?

ljharb · 2019-06-23T22:10:29Z

Yes, please.

ljharb

LGTM pending a nit

Includes fixes for the use of `eslint/lib/util/traverser` that is now removed in ESLint 6 Co-Authored-By: golopot <golopot@gmail.com>

It's now supported

sheepsteak · 2019-06-23T23:33:52Z

@ljharb OK I had to do one more thing and make testVersion take a function instead of an object so that require.resolve didn't get run and throw an error. This happens when trying to resolve the TypeScript parsers on test runs where they've been removed in dep-time-travel.sh. All tests pass on Travis now 🎉

frederikhors · 2019-06-24T19:23:35Z

Please @ljharb can you merge and release this? This is urgent now with eslint 6 in production everywhere (unfortunately).

"eslint": "2.x - 6.x"

ljharb · 2019-06-24T20:35:11Z

@frederikhors If npm ls exits nonzero, your dep graph is invalid, so eslint 6 shouldn't be in production when you have peer dep conflicts with it. If it's urgent for you, it's a problem of your own making.

frederikhors · 2019-06-24T20:53:25Z

@ljharb the problem is not mine but it is here: prettier/prettier-vscode#672

ljharb · 2019-06-24T21:14:17Z

Their problem is the same; upgrading to eslint v6 prior to peer deps upgrading is invalid.

frederikhors · 2019-06-25T19:35:31Z

@ljharb still same problem today.

sheepsteak mentioned this pull request Jun 23, 2019

eslint v6 support airbnb/javascript#2036

Closed

17 tasks done

ljharb requested changes Jun 23, 2019

View reviewed changes

chiawendt reviewed Jun 23, 2019

View reviewed changes

Comment thread package.json Outdated

ljharb reviewed Jun 23, 2019

View reviewed changes

ljharb approved these changes Jun 23, 2019

View reviewed changes

ljharb self-assigned this Jun 23, 2019

sheepsteak and others added 9 commits June 23, 2019 23:32

Transform output of FileEnumerator into what rule expects

b5ff64e

Add ecmaVersion when required

1029b4f

Use require.resolve when passing parser to RuleTester

e6ea127

Allow ESLint@6

2f1f4da

Update to @typescript-eslint/parser canary

c2b19d0

Includes fixes for the use of `eslint/lib/util/traverser` that is now removed in ESLint 6 Co-Authored-By: golopot <golopot@gmail.com>

Only run tests using typescript-eslint-parser on eslint@<6

d9b7258

Use eslint@6 instead of eslint@6.0.0-alpha in Travis

3bee716

Remove ESLint 6 from allowed failures in Travis

d7023f6

It's now supported

Make testVersion take a function to delay running require.resolve

7e41d29

ljharb merged commit c8132f2 into import-js:master Jun 24, 2019

frederikhors mentioned this pull request Jun 25, 2019

Cannot find module '../ast-utils' when formating prettier/prettier-vscode#672

Closed

	return Array.from(e.iterateFiles(src), ({ filePath, ignored })=>({
	return Array.from(e.iterateFiles(src), ({ filePath, ignored }) => ({

Uh oh!

Conversation

sheepsteak commented Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheepsteak commented Jun 23, 2019

Uh oh!

coveralls commented Jun 23, 2019

Uh oh!

coveralls commented Jun 23, 2019

Uh oh!

coveralls commented Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 23, 2019

Uh oh!

coveralls commented Jun 23, 2019

Uh oh!

coveralls commented Jun 23, 2019

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb commented Jun 23, 2019

Uh oh!

Uh oh!

ljharb Jun 23, 2019

Choose a reason for hiding this comment

Uh oh!

sheepsteak commented Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chiawendt commented Jun 23, 2019

Uh oh!

sheepsteak commented Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb commented Jun 23, 2019

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

sheepsteak commented Jun 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frederikhors commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb commented Jun 24, 2019

Uh oh!

frederikhors commented Jun 24, 2019

Uh oh!

ljharb commented Jun 24, 2019

Uh oh!

frederikhors commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

sheepsteak commented Jun 23, 2019 •

edited

Loading

coveralls commented Jun 23, 2019 •

edited

Loading

sheepsteak commented Jun 23, 2019 •

edited

Loading

sheepsteak commented Jun 23, 2019 •

edited

Loading

sheepsteak commented Jun 23, 2019 •

edited

Loading

frederikhors commented Jun 24, 2019 •

edited

Loading