fix: aliased internal modules that look like core modules - #1297
Merged
ljharb merged 2 commits intoApr 11, 2019
Merged
Conversation
echenley
commented
Mar 6, 2019
echenley
commented
Mar 6, 2019
ljharb
reviewed
Mar 6, 2019
ljharb
approved these changes
Mar 16, 2019
|
When will this PR be merged? |
ljharb
force-pushed
the
ech/fix-isBuiltIn-local-aliases
branch
from
April 11, 2019 22:22
9eed55b to
ba0aed9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
isBuiltInto returnfalseif a path is returned from a resolver.Previously an alias like 'constants/foo' would be classified as a builtin rather than internal since 'constants' is a core module of node. Fixes one of the issues mentioned in #1034.
Update webpack resolver to attempt to resolve modules internally before classifying them as builtin.
Add several tests to cover these cases.
Example
{ "settings": { "import/resolver": { "node": { "paths": ["/project/src"] } } } }Result: