Sitelet https://github.com/import-js/eslint-plugin-import/pull/1222
Skip to content

[New] named: add commonjs option - #1222

Merged
ljharb merged 2 commits into
import-js:masterfrom
vikr01:feature/named-require
Aug 5, 2021
Merged

[New] named: add commonjs option#1222
ljharb merged 2 commits into
import-js:masterfrom
vikr01:feature/named-require

Conversation

@vikr01

@vikr01 vikr01 commented Oct 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related: #1145

Adds an option commonjs to named rule, which will check a destructured require statement.

Invalid:

// ./foo.js
export const foo = 'bar';

// ./bar.js
const {baz} = require('./foo');

valid:

// ./bar.js
export const bar = 'foo';
export const foo = 'baz';

// ./baz.js
const {bar} = require('./bar');


// ./foo2.js
const {bar, foo} = require('./bar');

// ./foo3.js
let {bar} = require('./bar'), {foo} = require('./bar');

@coveralls

coveralls commented Oct 25, 2018

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 96.948% when pulling b776460 on vikr01:feature/named-require into b4a2f11 on benmosher:master.

1 similar comment
@coveralls

coveralls commented Oct 25, 2018

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 96.948% when pulling b776460 on vikr01:feature/named-require into b4a2f11 on benmosher:master.

@coveralls

coveralls commented Oct 25, 2018 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.4%) to 96.952% when pulling d13c122 on vikr01:feature/named-require into db471a8 on benmosher:master.

ljharb
ljharb reviewed Oct 26, 2018
View reviewed changes
Comment thread src/rules/named.js Outdated
Comment thread src/rules/named.js Outdated
Comment thread src/rules/named.js Outdated
Comment thread src/rules/named.js Outdated
Comment thread src/rules/named.js Outdated
Comment thread tests/src/rules/named.js Outdated
@vikr01 vikr01 mentioned this pull request Nov 2, 2018
Closed
@polgfred polgfred mentioned this pull request Jan 2, 2019
Open
@ljharb
ljharb requested a review from benmosher January 22, 2019 15:38
@ljharb
ljharb removed the request for review from benmosher August 5, 2021 05:17
@ljharb ljharb changed the title Check named exports on destructured require [New] named: add commonjs option Aug 5, 2021
@ljharb
ljharb merged commit 54d86c8 into import-js:master Aug 5, 2021
@vikr01
vikr01 deleted the feature/named-require branch August 5, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments

Assignees

No one assigned

Labels

semver-minor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikr01 @coveralls @ljharb