Fix polling after seek during playback - #271
Merged
maboa merged 1 commit intoJul 26, 2026
Merged
Conversation
happykawayigt
marked this pull request as ready for review
July 23, 2026 18:50
maboa
added a commit
that referenced
this pull request
Jul 26, 2026
- Highlighting no longer freezes after seeking during playback (#264, #271) - caption.js never derives negative durations / repairs inverted cues (#272, from hyperaudio/hyperaudio-lite-editor#411)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
handleSeeked()updated the visual state but left the timer scheduled from the pre-seek position. Seeking from a long silence into dense speech could therefore leave highlighting frozen until that stale timer fired.Validation
npm run buildnpm test -- --runInBand(72 tests passed)Fixes #264