Fix build issue with gcc15 - #84
Open
MatthewHartley wants to merge 2 commits into
Open
MatthewHartley wants to merge 2 commits into
MatthewHartley wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since gcc15 came out, I have had trouble building this project on my gentoo machine, with the error
httperf.c: In function ‘main’:
httperf.c:1384:24: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
1384 | signal(SIGINT, (void ()()) core_exit);
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| void ()(void)
In file included from httperf.c:60:
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void ()(int)’} but argument is of type ‘void ()(void)’
88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
| ~~~~~~~~~~~~~~~^~~~~~~~~
In file included from httperf.c:81:
./core.h:47:13: note: ‘core_exit’ declared here
47 | extern void core_exit (void);
| ^~~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
72 | typedef void (*__sighandler_t) (int);
| ^~~~~~~~~~~~~~
This change fixes the issue on my machine, but tips on how to not break this for people who have been successfully passing in core_exit directly to signal for years would be appreciated!