Sitelet https://github.com/hashicorp/consul/pull/23837
Skip to content

ci: update metrics-checker action - #23837

Open
vjymisal0 wants to merge 3 commits into
hashicorp:mainfrom
vjymisal0:fix-metrics-checker
Open

ci: update metrics-checker action#23837
vjymisal0 wants to merge 3 commits into
hashicorp:mainfrom
vjymisal0:fix-metrics-checker

Conversation

@vjymisal0

Copy link
Copy Markdown

Fixes #12515

This PR addresses the requested updates to the metrics-checker GitHub action:

  • S1: Indicates exactly which condition triggered the metrics check in the script's output.
  • S3: The action now only triggers on push/commits to PRs (changed events to \opened, \synchronize,
    eopened).
  • S4: The script now uses the PR's base branch instead of hardcoding \origin/main.

Note: S2 was already addressed in a previous PR (#13413).

Signed-off-by: vjymisal0 vijay.looprai@gmail.com

@vjymisal0
vjymisal0 requested review from a team as code owners August 18, 2026 17:39
Copilot AI lite review requested due to automatic review settings August 18, 2026 17:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@hashicorp-cla-app

hashicorp-cla-app Bot commented Aug 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Fixes hashicorp#12515
- Indicate which condition triggered the metrics check
- Only run on push/commits to PRs (removed labeled event, added reopened)
- Check diff against the PR's base branch instead of origin/main

Signed-off-by: vjymisal0 <vijay.looprai@gmail.com>
@vjymisal0
vjymisal0 force-pushed the fix-metrics-checker branch from fc2602d to 3165efe Compare August 19, 2026 12:25
@vjymisal0

vjymisal0 commented Aug 21, 2026

Copy link
Copy Markdown
Author

Hi maintainers,

The Vercel status check on this PR is failing with "Authorization required to deploy" - the Vercel preview deployment requires authorization from a member of the HashiCorp Vercel team, which external contributors do not have.

Could someone from the team either authorize/trigger the preview deployment manually, or configure Vercel to skip preview deploys for forked PRs? The changes here are CI-only (updating the metrics-checker action), so this check failure does not reflect any problem with the PR itself.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevOps] metrics-checker GitHub Action Update

2 participants