Sitelet https://github.com/grokability/snipe-it/pull/6485
Skip to content

Improve Memcached settings - #6485

Merged
snipe merged 2 commits into
grokability:masterfrom
benrubson:memcached
Dec 6, 2018
Merged

snipe merged 2 commits into
grokability:masterfrom
benrubson:memcached

Conversation

@benrubson

Copy link
Copy Markdown

Hi,

This PR adds Memcached settings into configuration file.
It also adds a configuration item for the cache prefix, if we have several Snipe-IT installation per (for instance) Memcached server.

Thank you 👍

@benrubson
benrubson requested a review from snipe as a code owner December 6, 2018 22:35
@snipe

snipe commented Dec 6, 2018 •

Copy link
Copy Markdown
Member

Hi @benrubson - this looks good, thanks! Normally we're a stickler for PRs to be made against develop while we're in between large version changes, but this change is simple enough that I can port it over.

Quick question - do you actually use Snipe-IT with memcached? I'm curious because we don't often hear about folks doing that, and I'm curious to know what your use case is.

@snipe
snipe merged commit 4ffb8f1 into grokability:master Dec 6, 2018
snipe added a commit that referenced this pull request Dec 6, 2018
@benrubson

Copy link
Copy Markdown
Author

Thank you too for having merged this @snipe 👍
Sorry I did not see the develop branch :|
I'm on a webserver hosting several tools, among them some require a Memcached server.
Then, as it is available here, using Memcached instead of files for Snipe-IT should improve page rendering by some ms, as disk is much more slower than memory.
Simply worth it 👍

@benrubson
benrubson deleted the memcached branch December 6, 2018 22:47
@snipe

snipe commented Dec 6, 2018

Copy link
Copy Markdown
Member

Oh of course. I'm not questioning the choice - Memcached is great. Just unusual to hear folks using it for Snipe-IT, as it tends to be a low-concurrency app and it's not particularly slow. (We have people running it on Raspberry Pi!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants