perf: better wcc - #888
Open
SemyonSinchenko wants to merge 2 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 79.26% 79.27%
=======================================
Files 81 81
Lines 4712 4713 +1
Branches 554 561 +7
=======================================
+ Hits 3735 3736 +1
Misses 977 977 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
lgtm |
Collaborator
Author
|
@james-willis this one is really around 2x better perf and 2x less RSS. I think you should consider to use it in Sedona instead of the default one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See #887
Why are the changes needed?
Close #887
It is 1.5x faster on local benchmarks while consuming 2x less amount of RAM. At scale should be ~2x faster than the two-phase-AQE and around 4x faster than the default.